From d48ef111c781d9bb7740264f6481cc2412093993 Mon Sep 17 00:00:00 2001 From: Andrii Anisov Date: Wed, 12 Dec 2018 20:20:55 +0200 Subject: [PATCH] arm/irq: skip action availability check for non-debug build Under desc->lock taken: An IRQ with _IRQ_GUEST flag set always has an action. An IRQ with _IRQ_DISABLED flag cleared always has an action. Those flags checks cover all accesses to desc->action in do_IRQ, so we can skip desc->action check in non-debug build. Keep in place for debug build to help diagnostics potential misconfiguration. Signed-off-by: Andrii Anisov Acked-by: Julien Grall --- xen/arch/arm/irq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index d6a0273d7a..4a02cc1eba 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -209,12 +209,14 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq) spin_lock(&desc->lock); desc->handler->ack(desc); +#ifndef NDEBUG if ( !desc->action ) { printk("Unknown %s %#3.3x\n", is_fiq ? "FIQ" : "IRQ", irq); goto out; } +#endif if ( test_bit(_IRQ_GUEST, &desc->status) ) { -- 2.30.2